feat(internal): add scope observer - #1839
Conversation
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
8bdc687 to
f015370
Compare
|
I got rid of the annoying |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1839 +/- ##
==========================================
+ Coverage 75.21% 75.57% +0.35%
==========================================
Files 91 91
Lines 21379 21588 +209
Branches 3764 3833 +69
==========================================
+ Hits 16081 16315 +234
+ Misses 4471 4440 -31
- Partials 827 833 +6 🚀 New features to boost your workflow:
|
limbonaut
left a comment
limbonaut
left a comment
There was a problem hiding this comment.
The most complete package among all SDKs, and well-covered. Nice work!
I left some suggestions for additional tests for you to consider if they're worth adding.
| if (g_scope.is_notifying > 0) { | ||
| // defer the flush requested by a reentrant scope change | ||
| g_scope.pending_flush = flush || g_scope.pending_flush; |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5ccbbeb. Configure here.
|
@limbonaut Thanks for the thorough review, great suggestions, and motivation to add more coverage! 🙏 |
3 participants
A callback-based observer API that fires when scope properties change:
Battle-tested by the upcoming WER integration (#1837)
and Crashpad IPC (#1840, abandoned).#skip-changelog (internal)