feat(scope): Scoped user feedback capture#1916
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## limbonaut/feat/apply-scope-to-feedback #1916 +/- ##
==========================================================================
+ Coverage 75.63% 75.66% +0.03%
==========================================================================
Files 93 93
Lines 22039 22056 +17
Branches 3925 3927 +2
==========================================================================
+ Hits 16669 16689 +20
+ Misses 4487 4485 -2
+ Partials 883 882 -1 🚀 New features to boost your workflow:
|
4f57ca8 to
7f225fa
Compare
1073ed7 to
b834d70
Compare
7f225fa to
e6f1d00
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e6f1d00. Configure here.
| options->run->cache_path, options->run->run_path); | ||
| } | ||
| } | ||
| sentry__attachments_free(all_attachments); |
There was a problem hiding this comment.
Local scope attachments dropped
Medium Severity
prepare_user_feedback applies and frees the passed-in scope but never merges local_scope->attachments into the envelope. Unlike sentry__prepare_event, only hint and global-scope attachments are included, so attachments set via sentry_scope_attach_* on the capture scope are silently omitted from scoped feedback.
Reviewed by Cursor Bugbot for commit e6f1d00. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
e6f1d00 to
4f57ca8
Compare
2 participants
Adds scoped capture of user feedback by introducing the
sentry_scope_capture_feedbackfunction, joining the existing family ofsentry_scope_capture_xfunctions. It layers the given scope on top of the global scope when building the feedback event, so a single capture can carry its own tags, user, and contexts without mutating global state.