Repository navigation
feat(billing): Add seer feature billing service protos - #477
Merged
Merged
Conversation
Add DATA_CATEGORY_BILLABLE_SEER_CREDITS and request/response messages for SeerFeatureBillingService, which maps Seer feature strings from LLM proxy cost data to billing data categories and reports which features are free. Refs REVENG-665
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
volokluev
commented
Oct 22, 2026
| message GetIsFreeSeerFeatureRequest { | ||
| // A Seer feature string, as recorded in LLM proxy cost data. | ||
| string feature_id = 1; | ||
| uint64 organization_id = 2; |
Member
Author
There was a problem hiding this comment.
features should either be free for everyone or they will be defined on the package as part of the billable metric if we need to look up per-org
Member
Author
There was a problem hiding this comment.
Removed in 00b61f0. getsentry/getsentry#22717 is updated to match.
A Seer feature is either free for every organization, or billed per org through a billable metric on the package.
volokluev
marked this pull request as ready for review
October 22, 2026 22:28
noahsmartin
approved these changes
Oct 22, 2026
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human summary
Somewhere we have to define which seer "features" (stored as strings in llm_proxy_cost_raw) are billable and what data category they map to. This service defines a concrete place to do that in configuration (see implementation PR for more details)
Bot shit
Adds
DATA_CATEGORY_BILLABLE_SEER_CREDITSand the messages for a newSeerFeatureBillingServicein getsentry.The billing usage service reads Seer LLM costs from
llm_proxy_cost_raw, where each row has a feature string (autofix,explorer,code_review, ...). This service tells it which data category each feature is billed under, and which features are never billed.GetMappingRequest/Response: feature string →DataCategory.GetIsFreeSeerFeatureRequest/Response: takesfeature_id, returnsis_free. A feature is free for every org or for none; per-org billing goes through a billable metric on the package.Refs REVENG-665