Repository navigation
feat(billing): Add snapshot image data category - #483
Open
noahsmartin wants to merge 2 commits into
Open
noahsmartin wants to merge 2 commits into
noahsmartin wants to merge 2 commits into
Conversation
Add DATA_CATEGORY_SNAPSHOT_IMAGE so billing platform line items can meter preprod snapshot images. Relay already emits outcomes for this category (SnapshotImage = 38), but billable metric expressions can only reference categories defined in this enum.
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
DATA_CATEGORY_SNAPSHOT_IMAGE = 35to the billingDataCategoryenum.Sentry already records accepted outcomes for preprod snapshot images: the snapshot upload endpoint calls
track_outcomewithDataCategory.SNAPSHOT_IMAGE(Relay'sSnapshotImage = 38), gated byorganizations:preprod-snapshot-billing-outcomes. Billing platform line items reference usage throughCategoryReference.data_category, so a snapshots SKU can't meter that usage until the category exists here.Follow-ups once this is released:
DataCategory.SNAPSHOT_IMAGEto the new proto value incategory_mapping.py