Skip to content

fix: Include query string and fragment in url.full span attribute#6861

Merged
sentrivana merged 5 commits into
masterfrom
ivana/fix-url-full-attribute
Jul 23, 2026
Merged

fix: Include query string and fragment in url.full span attribute#6861
sentrivana merged 5 commits into
masterfrom
ivana/fix-url-full-attribute

Conversation

@sentrivana

@sentrivana sentrivana commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

The url.full span attribute was only being set to the base URL (scheme + host + path), omitting query string and fragment.

Closes #6860

The `url.full` attribute was only being set to the base URL (scheme +
host + path), omitting query string and fragment. This affected aiohttp
(server and client), httpx, httpx2, and WSGI integrations. ASGI and
Quart were already correct.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sentrivana sentrivana changed the title fix: Include query string and fragment in url.full span attribute fix: Include query string and fragment in url.full span attribute Jul 22, 2026
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

95314 passed | ❌ 1 failed | ⏭️ 6340 skipped | Total: 101655 | Pass Rate: 93.76% | Execution Time: 329m 27s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests 📉 -1
Failed Tests 📈 +1
Skipped Tests

➕ New Tests (1)

View new tests
  • test_circular_references_span_streaming
    • File: tests.tracing.test_misc
    • Status: ❌ Failing

❌ Failed Tests

test_circular_references_span_streaming

File: tests.tracing.test_misc
Suite: py3.8-gevent
Error: assert 10 == 0 + where 10 = () + where = gc.collect

Stack Trace
tests/tracing/test_misc.py:379: in test_circular_references_span_streaming
    assert gc.collect() == 0
E   assert 10 == 0
E    +  where 10 = <built-in function collect>()
E    +    where <built-in function collect> = gc.collect

✅ Patch coverage is 93.48%. Project has 2508 uncovered lines.
✅ Project coverage is 89.69%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/aiohttp.py 80.00% ⚠️ 3 Missing and 1 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.68%    89.69%    +0.01%
==========================================
  Files          193       193         —
  Lines        24285     24320       +35
  Branches      8550      8570       +20
==========================================
+ Hits         21779     21812       +33
- Misses        2506      2508        +2
- Partials      1393      1393         —

Generated by Codecov Action

sentrivana and others added 4 commits July 23, 2026 09:17
…y/fragment

Resolved merge conflict in the client streaming path to combine
query/fragment appending with the data_collection gate. Fixed a bug
in the server-side should_send_default_pii path where url_full was
referenced before assignment.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sentrivana
sentrivana marked this pull request as ready for review July 23, 2026 08:38
@sentrivana
sentrivana requested a review from a team as a code owner July 23, 2026 08:38

@alexander-alderman-webb alexander-alderman-webb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sentrivana
sentrivana merged commit 9667284 into master Jul 23, 2026
398 of 402 checks passed
@sentrivana
sentrivana deleted the ivana/fix-url-full-attribute branch July 23, 2026 08:58
sentrivana added a commit that referenced this pull request Jul 23, 2026
…6861)

The `url.full` span attribute was only being set to the base URL (scheme
+ host + path), omitting query string and fragment.

Closes #6860

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit if the url.full attribute contains the full URL

2 participants