fix(replay): Forward Session Replay network detail options to native SDKs#6373
Merged
Conversation
…SDKs Network detail capture for Mobile Session Replay is implemented in the JS layer (xhrUtils enriches breadcrumbs), but the rrweb options event that tells the Sentry frontend to render request/response bodies and headers is emitted by the native SDKs from their SentryReplayOptions. RN never forwarded the network detail config to native, so SentryReplayOptions.networkDetailAllowUrls stayed empty, networkDetailHasUrls was false, and the frontend never rendered the captured details. Forward networkDetailAllowUrls, networkDetailDenyUrls, networkCaptureBodies, networkRequestHeaders and networkResponseHeaders from mobileReplayOptions into the native SentryReplayOptions on both platforms. RegExp allow/deny patterns can't cross the native bridge, so they are forwarded as their string source; JS-side matching in xhrUtils keeps using the original RegExp values. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
Author
|
@sentry review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 47cb22d. Configure here.
Allow-list the Spaceflight News API host and enable networkCaptureBodies so the sample exercises request/response detail rendering in the Replay network tab via the existing News screen. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
📲 Install BuildsAndroid
|
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f9c1ed4+dirty | 3833.98 ms | 1226.30 ms | -2607.68 ms |
| a50b33d+dirty | 1197.74 ms | 1197.17 ms | -0.57 ms |
| 7436d0f+dirty | 3851.58 ms | 1232.21 ms | -2619.38 ms |
| 5a21b51+dirty | 3823.11 ms | 1214.46 ms | -2608.65 ms |
| 09a902f+dirty | 3835.67 ms | 1217.11 ms | -2618.57 ms |
| ad66da3+dirty | 3820.96 ms | 1214.43 ms | -2606.52 ms |
| eb93136+dirty | 3843.09 ms | 1220.11 ms | -2622.98 ms |
| d2eadf8+dirty | 3842.42 ms | 1228.91 ms | -2613.50 ms |
| 1e5d96d+dirty | 3851.45 ms | 1212.05 ms | -2639.41 ms |
| 64630e5+dirty | 3842.70 ms | 1218.11 ms | -2624.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f9c1ed4+dirty | 4.98 MiB | 6.50 MiB | 1.53 MiB |
| a50b33d+dirty | 3.38 MiB | 4.73 MiB | 1.35 MiB |
| 7436d0f+dirty | 5.15 MiB | 6.70 MiB | 1.54 MiB |
| 5a21b51+dirty | 5.15 MiB | 6.67 MiB | 1.51 MiB |
| 09a902f+dirty | 4.98 MiB | 6.46 MiB | 1.49 MiB |
| ad66da3+dirty | 5.15 MiB | 6.67 MiB | 1.51 MiB |
| eb93136+dirty | 5.15 MiB | 6.69 MiB | 1.53 MiB |
| d2eadf8+dirty | 5.15 MiB | 6.67 MiB | 1.51 MiB |
| 1e5d96d+dirty | 4.98 MiB | 6.46 MiB | 1.49 MiB |
| 64630e5+dirty | 4.98 MiB | 6.46 MiB | 1.49 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f9c1ed4+dirty | 3842.09 ms | 1220.70 ms | -2621.40 ms |
| 1122a96+dirty | 3839.17 ms | 1219.23 ms | -2619.93 ms |
| 23598c3+dirty | 1223.59 ms | 1229.13 ms | 5.53 ms |
| 3ce5254+dirty | 1217.70 ms | 1224.69 ms | 6.99 ms |
| 68672fc+dirty | 3832.22 ms | 1228.29 ms | -2603.93 ms |
| 04207c4+dirty | 1228.55 ms | 1226.04 ms | -2.51 ms |
| 88735e9+dirty | 3837.80 ms | 1216.39 ms | -2621.41 ms |
| 09a902f+dirty | 3847.65 ms | 1221.31 ms | -2626.34 ms |
| 7ac3378+dirty | 1202.35 ms | 1198.31 ms | -4.04 ms |
| d2eadf8+dirty | 3841.53 ms | 1216.15 ms | -2625.39 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f9c1ed4+dirty | 4.98 MiB | 6.50 MiB | 1.53 MiB |
| 1122a96+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
| 23598c3+dirty | 3.38 MiB | 4.80 MiB | 1.42 MiB |
| 3ce5254+dirty | 3.38 MiB | 4.76 MiB | 1.38 MiB |
| 68672fc+dirty | 5.15 MiB | 6.71 MiB | 1.55 MiB |
| 04207c4+dirty | 3.38 MiB | 4.76 MiB | 1.38 MiB |
| 88735e9+dirty | 4.98 MiB | 6.46 MiB | 1.49 MiB |
| 09a902f+dirty | 4.98 MiB | 6.46 MiB | 1.49 MiB |
| 7ac3378+dirty | 3.38 MiB | 4.76 MiB | 1.38 MiB |
| d2eadf8+dirty | 5.15 MiB | 6.67 MiB | 1.51 MiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4b87b12+dirty | 356.23 ms | 399.86 ms | 43.63 ms |
| 5a21b51+dirty | 505.16 ms | 539.20 ms | 34.04 ms |
| d038a14+dirty | 405.08 ms | 444.36 ms | 39.28 ms |
| 5257d80+dirty | 472.37 ms | 494.54 ms | 22.17 ms |
| a50b33d+dirty | 353.21 ms | 398.48 ms | 45.27 ms |
| 5a23c47+dirty | 406.83 ms | 451.47 ms | 44.64 ms |
| acd838e+dirty | 492.90 ms | 551.42 ms | 58.52 ms |
| 2c735cc+dirty | 435.20 ms | 459.48 ms | 24.28 ms |
| 5ee78d6+dirty | 411.18 ms | 437.83 ms | 26.65 ms |
| 3a829f0+dirty | 410.78 ms | 454.22 ms | 43.44 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4b87b12+dirty | 43.94 MiB | 49.00 MiB | 5.06 MiB |
| 5a21b51+dirty | 48.30 MiB | 53.49 MiB | 5.19 MiB |
| d038a14+dirty | 48.30 MiB | 53.49 MiB | 5.19 MiB |
| 5257d80+dirty | 48.30 MiB | 53.58 MiB | 5.28 MiB |
| a50b33d+dirty | 43.94 MiB | 48.94 MiB | 5.00 MiB |
| 5a23c47+dirty | 49.74 MiB | 54.82 MiB | 5.07 MiB |
| acd838e+dirty | 48.30 MiB | 53.60 MiB | 5.30 MiB |
| 2c735cc+dirty | 43.94 MiB | 48.94 MiB | 5.00 MiB |
| 5ee78d6+dirty | 48.30 MiB | 53.58 MiB | 5.28 MiB |
| 3a829f0+dirty | 48.30 MiB | 53.58 MiB | 5.28 MiB |
…twork-detail-options
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5569641+dirty | 406.43 ms | 428.51 ms | 22.08 ms |
| 3d377b5+dirty | 406.18 ms | 453.52 ms | 47.34 ms |
| 3b6e9f9+dirty | 442.70 ms | 486.44 ms | 43.74 ms |
| b04af96+dirty | 496.48 ms | 557.88 ms | 61.40 ms |
| 68ae91b+dirty | 416.44 ms | 477.56 ms | 61.12 ms |
| f3215d3+dirty | 411.11 ms | 454.38 ms | 43.27 ms |
| 0d9949d+dirty | 403.57 ms | 437.00 ms | 33.43 ms |
| 6176a94+dirty | 410.90 ms | 452.20 ms | 41.31 ms |
| 4b87b12+dirty | 421.82 ms | 413.60 ms | -8.22 ms |
| a50b33d+dirty | 500.81 ms | 532.11 ms | 31.30 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5569641+dirty | 48.30 MiB | 53.48 MiB | 5.18 MiB |
| 3d377b5+dirty | 43.75 MiB | 48.14 MiB | 4.39 MiB |
| 3b6e9f9+dirty | 48.30 MiB | 53.54 MiB | 5.23 MiB |
| b04af96+dirty | 49.74 MiB | 55.00 MiB | 5.26 MiB |
| 68ae91b+dirty | 49.74 MiB | 54.79 MiB | 5.05 MiB |
| f3215d3+dirty | 48.30 MiB | 53.49 MiB | 5.19 MiB |
| 0d9949d+dirty | 43.75 MiB | 48.13 MiB | 4.37 MiB |
| 6176a94+dirty | 48.30 MiB | 53.54 MiB | 5.24 MiB |
| 4b87b12+dirty | 43.75 MiB | 48.14 MiB | 4.39 MiB |
| a50b33d+dirty | 43.75 MiB | 48.08 MiB | 4.33 MiB |
antonis
commented
Jun 30, 2026
antonis
left a comment
antonis
left a comment
Contributor
Author
There was a problem hiding this comment.
Noting that the failed Sample Application / Test android production REV2 is unrelated with the changes on this PR and will be fixed with #6378
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Enhances the network detail capture for Mobile Session Replay (added in #6288) by forwarding the network-detail options into the native
SentryReplayOptionson both platforms💡 Motivation and Context
Follow-up to #6288
💚 How did you test it?
CI checks and tests, Manual (example iOS, example Android)
📝 Checklist
sendDefaultPiiis enablednetworkDetailAllowUrls(empty by default); auth-like headers are always stripped in the JS layer.🔮 Next steps