Repository navigation
ref(grouping): Add and update Unity grouping test inputs - #129052
Merged
Merged
Conversation
lobsterkatie
marked this pull request as ready for review
October 28, 2026 18:37
RudraPatel2003
approved these changes
Oct 28, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies and adds to our existing grouping snapshot inputs for Unity, to make them more realistic and cover more platforms. Credit goes to @bitsandfoxes for the work - I'm merely splitting the input changes out from #122130, so that its diff can reflect only the snapshot changes actually caused by its code changes. From his comment on that PR, notes on the new and changed inputs here:
unity_coroutine_dispatch.jsonnow uses the frame shapesentry-unityactually sends (function:"InvokeMoveNext"with the type in module). The fully qualified names never matched the rule, so the snapshot wasn't exercising it.unity_il2cpp_ios.jsongains the-[UnityFramework runUIApplicationMainWithArgc:argv:]frame that real builds have betweenmainandUIApplicationMain.