Repository navigation
ref(integrations): Separate SCM file check metrics - #129169
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
giovanni-guidini
force-pushed
the
gio/feat/migrate-scm-file-checks
branch
from
October 29, 2026 12:35
b172716 to
ebc0761
Compare
github-actions
Bot
added
the
Scope: Frontend
giovanni-guidini
changed the title
giovanni-guidini
changed the base branch from
gio/feat/add-scm-milestone-metrics
to
master
October 29, 2026 12:35
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introducedType assertions (
This is informational only and does not block the PR. |
giovanni-guidini
force-pushed
the
gio/feat/migrate-scm-file-checks
branch
from
October 29, 2026 12:43
ebc0761 to
0f2dfaf
Compare
github-actions
Bot
removed
the
Scope: Frontend
giovanni-guidini
marked this pull request as ready for review
October 29, 2026 12:47
joseph-sentry
approved these changes
Oct 29, 2026
joseph-sentry
left a comment
joseph-sentry
left a comment
Contributor
There was a problem hiding this comment.
same feedback as the other PR where parent interaction type can live in a contextvar
giovanni-guidini
force-pushed
the
gio/feat/migrate-scm-file-checks
branch
2 times, most recently
from
November 2, 2026 08:56
0f389ff to
02c3721
Compare
Keep stack-trace and CODEOWNERS feature outcomes on integration SLOs while recording internal file checks with one bounded operational counter. Refs SCM-304
giovanni-guidini
force-pushed
the
gio/feat/migrate-scm-file-checks
branch
from
November 2, 2026 09:03
02c3721 to
a151488
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves internal file checks for stack-trace linking and CODEOWNERS resolution out of feature SLOs and records them with a bounded regular metric tagged by provider, parent feature, and result. This keeps
integrations.slo.*focused on complete feature outcomes and advances SCM-304.Why do I want this?
We defined a set of features that are powered by SCM connections (so the SCM team cares about them).
Reviewing the existing SLOs and alerts we were alerting on partial feature results as well, and using a full "lifecycle" idea for parts of a feature. While they might be important operations that should still be emitted as metrics we want to keep the high level alerts focused on the full feature health.
So I'm demoting these partial steps to "regular metrics" not "lifecycle steps"