Skip to content

ref(integrations): Separate SCM repository list metrics - #129183

Merged
giovanni-guidini merged 5 commits into
masterfrom
gio/refactor/demote-get-repositories
Nov 2, 2026
Merged

giovanni-guidini merged 5 commits into
masterfrom
gio/refactor/demote-get-repositories

Conversation

@giovanni-guidini

Copy link
Copy Markdown
Contributor

Moves GitHub and GitHub Enterprise repository-list operations out of integrations.slo.* and records one regular metric tagged by provider, parent feature, and bounded result. Parent attribution now flows through repository choices, search, linking and sync, and derived code mappings, keeping complete feature lifecycles authoritative while preserving operational drill-down. This advances SCM-304.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 29, 2026
@giovanni-guidini
giovanni-guidini marked this pull request as ready for review October 29, 2026 13:54
@giovanni-guidini
giovanni-guidini requested review from a team as code owners October 29, 2026 13:54

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@joseph-sentry joseph-sentry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the general approach it'd be cool if we could avoid piping through the parent interaction type through all the functions & instead use a context var so we set it in one place

just something to consider

Copy link
Copy Markdown
Contributor Author

That's true… maybe even as part of the lifecycle start we can just say to which feature this belongs… I'll adjust, thanks for the suggestion

@giovanni-guidini

Copy link
Copy Markdown
Contributor Author

Updated the implementation so SCM lifecycle entry sets the active feature in a ContextVar and exit restores the previous value. Repository-list telemetry now reads that context directly, so the cross-provider parameter plumbing is gone; nested and exceptional lifecycle exits are covered. I also changed pagination truncation from error to the bounded halted result.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5a9ebe4. Configure here.

Prevent reused lifecycle objects from overwriting their active SCM interaction context.

Refs SCM-304
@giovanni-guidini
giovanni-guidini merged commit b8ed074 into master Nov 2, 2026
80 checks passed
@giovanni-guidini
giovanni-guidini deleted the gio/refactor/demote-get-repositories branch November 2, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants