Repository navigation
ref(typing): Let serialize() take a service account - #129412
Merged
gricha merged 1 commit intoNov 2, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
gricha
changed the base branch from
ref/mypy-request-user-principal
to
ref/principal-helper-examples
November 1, 2026 04:24
gricha
force-pushed
the
ref/typing-serialize-principal
branch
from
November 1, 2026 04:24
f00e055 to
6f0e130
Compare
gricha
force-pushed
the
ref/typing-serialize-principal
branch
from
November 2, 2026 19:55
6f0e130 to
ebde3ee
Compare
gricha
marked this pull request as ready for review
November 2, 2026 20:04
azulus
approved these changes
Nov 2, 2026
gricha
force-pushed
the
ref/typing-serialize-principal
branch
from
November 2, 2026 22:08
ebde3ee to
587525d
Compare
gricha
force-pushed
the
ref/typing-serialize-principal
branch
2 times, most recently
from
November 2, 2026 23:08
ce18955 to
416a8a7
Compare
Contributor
Sentry Snapshot Testing
|
request.user can be a ServiceAccountPrincipal, and endpoints already pass it to serialize(), whose serializers handle it. The signature now says so. Type-only.
gricha
force-pushed
the
ref/typing-serialize-principal
branch
from
November 2, 2026 23:18
416a8a7 to
3290059
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Endpoints pass
request.usertoserialize(), and it can be a service account. Serializers already handle that at runtime, but the signature saidUser | RpcUser | AnonymousUser | None. It now takes aRequestPrincipal | None.Type-only. Without it, #129402's mypy check would flag 160 files that only pass
request.usertoserialize().Serializer methods (
get_attrs/serialize) still declare the old user type;serialize()hands them an untyped serializer, so nothing here hides an error. Widening the serializer tree itself is a later step.