Repository navigation
Conversation
github-actions
Bot
added
the
Scope: Backend
gricha
force-pushed
the
ref/sa-narrow-core
branch
from
November 1, 2026 04:24
7bae012 to
138bfdc
Compare
Organization, project, team and SCIM endpoints read the caller through `sentry.auth.principal`: "my projects" and own-membership lookups use `owned_by_acting_user()`, "is this mine?" uses `is_acting_user()`, nullable actor ids use `acting_user_id()`, and org creation, the owner-only org list and username/email reads use `require_user()`. - A service account gets an empty "my projects" (`is_member:1`, project counts) instead of 403. Requesting a closed team for a member now files an access request with no requester; before, it wrote the row and then returned 403. A project PUT with `isBookmarked` saves the update and skips the bookmark, as it always did for token callers; before, it saved part of the update and then returned 403. New tests cover all three. - Token callers no longer count teamless projects or invited (null-user) members as theirs. - Users and agents see no change.
gricha
force-pushed
the
ref/sa-narrow-core
branch
from
November 1, 2026 04:57
138bfdc to
b98b96b
Compare
Contributor
Sentry Snapshot Testing
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Organization, project, team and SCIM endpoints read the caller through
sentry.auth.principal: "my projects" and own-membership lookups useowned_by_acting_user(), "is this mine?" usesis_acting_user(), nullable actor ids useacting_user_id(), and org creation, the owner-only org list and username/email reads userequire_user().is_member:1, project counts) instead of 403. Requesting a closed team for a member now files an access request with no requester; before, it wrote the row and then returned 403. A project PUT withisBookmarkedsaves the update and skips the bookmark, as it always did for token callers; before, it saved part of the update and then returned 403. New tests cover all three.Member management (member details PUT/DELETE, member invites, invite requests,
get_allowed_org_roles) is deliberately unchanged: whether a service account may manage members is still open, so it keeps getting 403user-requiredand those files stay on #129402's mypy allowlist.