Repository navigation
Conversation
The group search view serializer allows anonymous users but looked up last-visited and starred rows with a null user id, which cannot match. Skip both queries for anonymous users; the serialized output is unchanged.
github-actions
Bot
added
the
Scope: Backend
This was referenced Oct 31, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavioral split from #129431 (performance-only).
GroupSearchViewSerializer.get_attrsaccepts anonymous users but queriedGroupSearchViewLastVisitedandGroupSearchViewStarredwith a null user id. Those rows cannot match, so skip both queries for anonymous users. The serialized response is unchanged.This also removes the null-user-id assumption the typing pass had to narrow around.