Repository navigation
Conversation
Artifact headers come from uploaded manifests. Treat a non-string sourcemap or x-sourcemap value as absent instead of passing it into force_bytes, and cover the accessor directly.
github-actions
Bot
added
the
Scope: Backend
The helper returns the raw string header; convert it to bytes in a separate variable so the variable keeps one type through the archive lookup paths.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavioral split from #129431 (cast audit).
Artifact headers come from uploaded manifests and are typed as
object. A non-stringsourcemaporx-sourcemapvalue was passed intoforce_bytes, which assumes a string. Treat non-string values as absent at the accessor and cover it directly.This also removes the trust-boundary casts from the source map debug endpoint.