Skip to content

ref(flags): Remove preprod-size-analysis-pr-comments backend reads - #129453

Open
cursor[bot] wants to merge 1 commit into
masterfrom
claude-rm-preprod-size-analysis-pr-comments-backend
Open

cursor[bot] wants to merge 1 commit into
masterfrom
claude-rm-preprod-size-analysis-pr-comments-backend

Conversation

@cursor

@cursor cursor Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Remove the organizations:preprod-size-analysis-pr-comments gate from the size PR comment task. This flag was rolled out to GA in the automator in #8928 on 8/3/26 (conditions: [], rollout: 100) and hasn't been touched since.

The surviving gate is the per-project option sentry:preprod_size_pr_comments_enabled, which resolve_pr_comment_context already checks and which test_skips_when_project_option_disabled already covers. That option is now the only off switch for this feature.

resolve_pr_comment_context's optional feature_flag parameter had no other user — the build-distribution caller dropped it in #120632 and the snapshot caller passes None — so the parameter and its gate are removed rather than left dead. test_skips_when_feature_flag_disabled asserts behavior that no longer exists and is deleted, matching what #120632 did for the sibling flag.

Frontend gate removal: #129452. Follow-up PRs remove the automator value and then the temporary.py registration, in that order.

Stale flag cleanup; flagged by the feature-flag scanner as ga-ready-to-graduate.

Open in Web View Automation 

The flag has been at rollout 100 for all orgs in the automator since
#8928 (8/3/26), so the size PR comment task now runs for every org whose
project has `sentry:preprod_size_pr_comments_enabled` set.

`resolve_pr_comment_context` had no other caller passing a feature flag,
so the parameter and its gate go with it.

Co-authored-by: charlie.luo <charlie.luo@sentry.io>
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 1, 2026
@cursor
cursor Bot requested a review from mtopo27 November 1, 2026 20:20

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@getsentry/emerge-tools — stale feature flag cleanup for organizations:preprod-size-analysis-pr-comments, 2 of 4.

Merge order:

  1. #129452 — frontend gate
  2. #129453 (this one) — backend reads
  3. getsentry/sentry-options-automator#10416 — the flagpole value
  4. #129454 — the temporary.py registration

The one hunk worth thinking about is dropping the feature_flag parameter from resolve_pr_comment_context rather than leaving it in place. After this change no caller passes it: the build-distribution task dropped it in #120632, the snapshot task passed an explicit None, and the size task was the last real user. Keeping an always-None parameter plus its dead features.has branch seemed worse than removing both, but happy to keep the signature if you'd rather.

After this, sentry:preprod_size_pr_comments_enabled on the project is the only remaining off switch for size PR comments — flagging that explicitly since the org-scoped kill path goes away with the flag. test_skips_when_project_option_disabled already covers it, which is why test_skips_when_feature_flag_disabled is deleted rather than retargeted (same call #120632 made for the sibling flag).

Verified with ruff check, ruff format --check, and sentry's standalone flake8_plugin checks on all four changed files. No local venv here, so the pytest run is CI's.

getsentry dispatch will fail — it gates on the author having write permission and the author is cursor[bot]. A collaborator needs to add the Trigger: getsentry tests label.

View PR

Open in Web View Automation 

Sent by Cursor Automation: Feature flag cleanup

@cursor
cursor Bot marked this pull request as ready for review November 1, 2026 20:27
@cursor
cursor Bot requested a review from a team as a code owner November 1, 2026 20:27

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant