Repository navigation
ref(flags): Remove preprod-size-analysis-pr-comments backend reads - #129453
cursor[bot] wants to merge 1 commit into
Conversation
The flag has been at rollout 100 for all orgs in the automator since #8928 (8/3/26), so the size PR comment task now runs for every org whose project has `sentry:preprod_size_pr_comments_enabled` set. `resolve_pr_comment_context` had no other caller passing a feature flag, so the parameter and its gate go with it. Co-authored-by: charlie.luo <charlie.luo@sentry.io>
There was a problem hiding this comment.
@getsentry/emerge-tools — stale feature flag cleanup for organizations:preprod-size-analysis-pr-comments, 2 of 4.
Merge order:
- #129452 — frontend gate
- #129453 (this one) — backend reads
- getsentry/sentry-options-automator#10416 — the flagpole value
- #129454 — the
temporary.pyregistration
The one hunk worth thinking about is dropping the feature_flag parameter from resolve_pr_comment_context rather than leaving it in place. After this change no caller passes it: the build-distribution task dropped it in #120632, the snapshot task passed an explicit None, and the size task was the last real user. Keeping an always-None parameter plus its dead features.has branch seemed worse than removing both, but happy to keep the signature if you'd rather.
After this, sentry:preprod_size_pr_comments_enabled on the project is the only remaining off switch for size PR comments — flagging that explicitly since the org-scoped kill path goes away with the flag. test_skips_when_project_option_disabled already covers it, which is why test_skips_when_feature_flag_disabled is deleted rather than retargeted (same call #120632 made for the sibling flag).
Verified with ruff check, ruff format --check, and sentry's standalone flake8_plugin checks on all four changed files. No local venv here, so the pytest run is CI's.
getsentry dispatch will fail — it gates on the author having write permission and the author is cursor[bot]. A collaborator needs to add the Trigger: getsentry tests label.
Sent by Cursor Automation: Feature flag cleanup


Remove the
organizations:preprod-size-analysis-pr-commentsgate from the size PR comment task. This flag was rolled out to GA in the automator in #8928 on 8/3/26 (conditions: [],rollout: 100) and hasn't been touched since.The surviving gate is the per-project option
sentry:preprod_size_pr_comments_enabled, whichresolve_pr_comment_contextalready checks and whichtest_skips_when_project_option_disabledalready covers. That option is now the only off switch for this feature.resolve_pr_comment_context's optionalfeature_flagparameter had no other user — the build-distribution caller dropped it in #120632 and the snapshot caller passesNone— so the parameter and its gate are removed rather than left dead.test_skips_when_feature_flag_disabledasserts behavior that no longer exists and is deleted, matching what #120632 did for the sibling flag.Frontend gate removal: #129452. Follow-up PRs remove the automator value and then the
temporary.pyregistration, in that order.Stale flag cleanup; flagged by the feature-flag scanner as
ga-ready-to-graduate.