Skip to content

ref(flags): Graduate organizations:autofix-browser-notifications in the UI - #129455

Open
cursor[bot] wants to merge 1 commit into
masterfrom
claude-rm-autofix-browser-notifications
Open

cursor[bot] wants to merge 1 commit into
masterfrom
claude-rm-autofix-browser-notifications

Conversation

@cursor

@cursor cursor Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Remove the frontend reads of organizations:autofix-browser-notifications. The flag was rolled out to GA (rollout: 100, conditions: []) in the automator in getsentry/sentry-options-automator#9026 on 8/3, and hasn't been touched since.

The one hunk that isn't mechanical. The flagpole block is not a plain GA: a Disable for sandbox org segment sits above the GA segment, so the feature evaluates false for the sandbox org. That exclusion is load-bearing — /organizations/{org}/issues/{id}/autofix/ uses GroupAiPermission, which allows POST for demo users "in order to showcase AI features in demo mode", so a sandbox visitor can put a run into processing and would be asked for browser notification permission. The collapse is therefore !isDemoModeActive() rather than an unconditional true, in both readers, with a new spec covering it. Happy to drop that and collapse to true if the team would rather handle the sandbox differently.

Follow-ups, in order: remove the flagpole value, then the temporary.py registration.

Verified locally: pnpm test-ci static/app/components/events/autofix (21 suites / 406 tests), pnpm run typecheck, pnpm run lint:js, pnpm run lint:format all pass.

Open in Web View Automation 

…he UI

The flag has been GA (rollout 100, conditions []) since automator #9026 on
2026-08-03. Its only non-GA segment disables the feature for the `sandbox`
org, which `isDemoModeActive()` expresses in the frontend.

Co-authored-by: charlie.luo <charlie.luo@sentry.io>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 1, 2026
@cursor
cursor Bot marked this pull request as ready for review November 1, 2026 20:39
@cursor
cursor Bot requested a review from a team as a code owner November 1, 2026 20:39
@cursor
cursor Bot requested a review from ryan953 November 1, 2026 20:39

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@getsentry/machine-learning-ai (CODEOWNERS for /static/app/components/events/autofix/) — this graduates organizations:autofix-browser-notifications, opened by the stale-flag-cleanup automation. @ryan953 is requested as reviewer since he created the flag (#119737), wrote both readers, and rolled it out in getsentry/sentry-options-automator#9026.

Merge order: this PR → getsentry/sentry-options-automator#10417 (flagpole value) → #129456 (temporary.py registration).

The one hunk to actually review is the sandbox handling. The flagpole block is not a plain GA — a Disable for sandbox org segment sits above the GA segment, so the flag evaluates false for the sandbox org, which the eval output in #9026 confirms. That exclusion is reachable rather than theoretical: GroupAiPermission on /organizations/{org}/issues/{id}/autofix/ sets ALLOWED_METHODS = SAFE_METHODS + ["POST"] with the comment "We want to allow POST requests in order to showcase AI features in demo mode", so a sandbox visitor can put a run into processing and reach SeerEnableNotifications. Collapsing to a bare true would start asking demo visitors for browser notification permission.

So the collapse is !isDemoModeActive() in both readers, plus a spec for it. Note it is not byte-identical to the org-slug rule: demoMode in the client config is is_demo_mode_enabled() and is_demo_user(user), so a logged-in employee browsing the sandbox now gets notifications where flagpole said no. If you would rather collapse to plain true and drop the sandbox special-case entirely, say so and I will.

CI is green apart from getsentry dispatch, which gates on the author having write permission and always fails for cursor[bot] — a collaborator needs to add the Trigger: getsentry tests label. Verified locally: pnpm test-ci static/app/components/events/autofix (21 suites, 406 tests), pnpm run typecheck, pnpm run lint:js, pnpm run lint:format.

View PR

Open in Web View Automation 

Sent by Cursor Automation: Feature flag cleanup

This branch was successfully deployed

1 active deployment
Preview — 8a3aa418 Deployed Nov 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant