Repository navigation
fix(repository): Bound repository sync lookups - #129473
giovanni-guidini wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Backend
Sentry Snapshot Testing
|
| ) | ||
| legacy_repos = self._adoptable_repositories( | ||
| organization.id, | ||
| external_ids=external_id_list, |
There was a problem hiding this comment.
Will the additional external_ids filter allow the service calls that create candidates to behave correctly? It looks like they would filter the return of those service calls so that the taken check on line 188 wouldn't work the same anymore.
There was a problem hiding this comment.
Apparently given the set of external_ids, and the fact that the way a row can be considered "taken" involves the external_id it doesn't matter if you filter before or after.
From clanker:
The filtering and adoptability check commute for the requested IDs. For a candidate with external ID A, only a canonical row with external ID A can mark it as taken. Filtering both candidates and taken by the same requested set therefore cannot remove a relevant blocker.
Also test_create_repositories__does_not_adopt_over_an_existing_row was not added by this PR but seems to show the behavior remains correct
Pass known external IDs through repository creation, removal, disable, and restore paths so RPC workers do not serialize every repository in an organization. Fixes SCM-327
f7a86bd to
b313041
Compare
Passes known external IDs through repository creation, webhook removal, disable, and restore paths so cell RPC workers only serialize the requested repositories instead of every repository in the organization. This is stacked on PR #129472 and must deploy only after that RPC contract is available in every cell. Fixes SCM-327.
Made with Cursor