Repository navigation
fix(jira): require a query for issue search - #129619
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Backend
sentry-junior
Bot
force-pushed
the
josh/typing-strict-types-only
branch
from
November 3, 2026 00:31
9fda5d0 to
73fa505
Compare
Co-Authored-By: Joshua Li <14209781+joshuarli@users.noreply.github.com>
sentry-junior
Bot
force-pushed
the
josh/typing-stack/jira-search-query-required
branch
from
November 3, 2026 00:34
7cbbba9 to
43d1e56
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #129614 (strict mypy, types only). This is #129430 rebased onto it so the fix lands after the typing PR.
A
Nonequery reached the Jira clients and failed with anAttributeErrororTypeError. Fail at the integration boundary instead, for both Jira Cloud and Jira Server. Both search endpoints already reject empty queries before they call this method. This replaces thecast(str, query)that #129614 kept.No new test: the existing endpoint tests cover the empty-query guards, and the assertion can't be reached from them.
via @joshuarli.
--
View Session [Sentry]