Repository navigation
fix(projects): return an empty list for blank allowed domains - #129624
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Backend
sentry-junior
Bot
force-pushed
the
josh/typing-strict-types-only
branch
from
November 3, 2026 00:31
9fda5d0 to
73fa505
Compare
sentry-junior
Bot
force-pushed
the
josh/typing-stack/empty-list-field-blank
branch
from
November 3, 2026 00:34
b1e32e8 to
066d13b
Compare
sentry-junior
Bot
force-pushed
the
josh/typing-stack/empty-list-field-blank
branch
from
November 3, 2026 12:02
066d13b to
d681856
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #129614 (strict mypy, types only). This is #129438 rebased onto it so the fix lands after the typing PR.
EmptyListFieldreturned a bare empty string for blank input, which breaks the DRFListFieldcontract. Return an empty list instead.validate_allowedDomainsalready filters falsy values and rejects the resulting empty list, so endpoint behavior doesn't change.Change from #129438: #129438 called
super().to_internal_value(list(data)).list()turns a non-empty string like"abc"into["a", "b", "c"], which skips DRF's "Expected a list" check, and it also skips the HTML form-list parsing. The field now passesdatathrough unchanged. Addedtest_non_empty_string_is_not_split_into_items.via @joshuarli.
--
View Session [Sentry]