Repository navigation
Conversation
pbhandari
requested changes
Oct 22, 2026
| crate-type = ["cdylib", "rlib"] | ||
|
|
||
| [dependencies] | ||
| rdkafka = { version = "0.37", features = ["zstd"] } |
Contributor
There was a problem hiding this comment.
Why do we need to pull in rdkafka? We use arroyo instead. Also zstd is already a dependency of this repo.
Member
Author
There was a problem hiding this comment.
arroyo's rdkafka dep doesn't use the zstd feature. But I can update arroyo and then bump the version here.
zstd being a dependency already is not enough.
Contributor
There was a problem hiding this comment.
I would definitely prefer updating arroyo instead of adding rdkafka as a dependency here unless there's a good reason as to why we can't do it that way.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable zstd support for kafka in order to measure how much zstd outperforms lz4 in s4s2 (potential cost saving).