Repository navigation
feat(llm-proxy-cost): Make llm_proxy_cost_raw writable through its entity - #8607
Merged
Merged
Conversation
…tity The test insert endpoints (/tests/entities/<entity>/insert and /tests/<entity>/eventstream) write through the entity's writable storage. With is_writable: false, they fail on llm_proxy_cost_raw, so Sentry and getsentry tests cannot store LLM proxy costs. The outcomes entity marks outcomes_raw writable for the same reason.
volokluev
marked this pull request as ready for review
October 26, 2026 20:22
MeredithAnya
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
is_writable: truefor thellm_proxy_cost_rawstorage on its entity.The test insert endpoints (
/tests/entities/<entity>/insertand/tests/<entity>/eventstream) write throughentity.get_writable_storage(). Withis_writable: false, that returnsNoneand the request fails with anAssertionError, so Sentry and getsentry tests cannot store LLM proxy costs. Theoutcomesentity marksoutcomes_rawwritable for the same reason.Production writes come from the
snuba-llm-proxy-costconsumer through the storage, so they do not change.Needed by getsentry/getsentry#22765, which tests the billing usage service against real
llm_proxy_cost_rawrows.