Repository navigation
feat(client): Use span streaming exclusively - #828
Merged
Merged
Conversation
Drop the transaction-based tracing path and always use the sentry_sdk.traces span streaming API. Bump sentry-sdk to 2.73.0. Apps using taskbroker-client must set trace_lifecycle="stream" in sentry_sdk.init(), otherwise no taskworker spans are emitted. - Rename sdk.start_transaction to start_segment - Set sentry.origin on streamed spans (previously defaulted to "manual") - Remove task args/kwargs span data, which was only set on transactions
sentrivana
marked this pull request as ready for review
October 22, 2026 11:27
untitaker
approved these changes
Oct 22, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry already uses span streaming, so remove the legacy transaction-based-tracing paths.
This is a prerequisite to ultimately move taskbroker to SDK 3.0, which supports span streaming exclusively.
Drop the transaction-based tracing path from the Python client and always use the
sentry_sdk.tracesspan streaming API. Bumpssentry-sdkto>=2.73.0.Breaking: apps using
taskbroker-clientmust settrace_lifecycle="stream"insentry_sdk.init(). Otherwise the SDK returns no-op spans (and warns on every task), so no taskworker spans are emitted.Changes:
sdk.py: remove thehas_span_streaming_enabledbranching,start_transaction, andset_datacalls. Renamestart_transactiontostart_segment.sentry.originon streamed spans. The streaming path previously didn't, so spans reportedmanualinstead oftaskworker.taskworker-task.args/kwargsspan data. This was only ever set on transactions; it was deliberately skipped for streamed spans because eager serialization increases memory use.start_transactionusage and drop thestatictrace lifecycle parametrization.