Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
requested changes
Oct 29, 2026
| - name: Build standalone CLI | ||
| run: pnpm --filter sentry run build | ||
| - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| with: |
Member
There was a problem hiding this comment.
We should defer this step after the standalone build and use that already-built artifact for e2e tests. This should also save us time.
Member
Author
There was a problem hiding this comment.
The Node 24 switch already follows the standalone build and E2E reuses the binary via SENTRY_CLI_BINARY.
also removed the duplicate standalone build from the CLI project job
Member
There was a problem hiding this comment.
???
The lines above this literally are:
- name: Build project dependencies
run: pnpm --filter 'sentry^...' --if-present run build
- run: pnpm --filter sentry run ci:prepare
- name: Build standalone CLI
run: pnpm --filter sentry run tsx script/build.ts --single
Which builds the dependencies and gets a new CLI build. We should be using the build going in for nightly which means we need to download it from a previous job as an artifact.
BYK
requested changes
Oct 30, 2026
| assert.doesNotMatch(workflow.split("\njobs:", 1)[0], /paths(?:-ignore)?:/); | ||
| }); | ||
|
|
||
| it("runs CLI E2E independently after project discovery", () => { |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original CLI job had a 12m26s median. Run E2E in parallel and remove repeated preparation/builds; the latest Test run took 10m21s (single run).
Reuse the standalone build, build the npm package once, and share Node version pins. Standalone and npm tests remain covered. CodeQL is unchanged.