Repository navigation
fix(fetcher): Tolerate missing unit key in warn_multiple_units - #80
Merged
Merged
Conversation
Datadog can omit the unit key from a series entirely instead of returning null. Treat a missing key the same as null so the cronjob no longer crashes with KeyError. Refs PRODENG-2990 Co-Authored-By: Trent Schmidt <trent.schmidt@sentry.io>
BojanOro
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PRODENG-2990.
Datadog sometimes returns a timeseries with no
unitkey at all, where it used to return"unit": null.parse_and_assert_unitalready handles this when the query file configures a unit, butwarn_multiple_unitsindexedseries_list[0]["unit"]directly and raisedKeyError: 'unit'. That crashed the usage-accountant cronjob in every region.This switches it to
.get("unit"), so a missing unit is handled the same way as null. It also adds amain()test with a configured unit and a series that has nounitkey. Without the fix, the test fails with the sameKeyError.via Trent Schmidt.
--
View Junior Session [Sentry]