Repository navigation
fix(fetcher): Handle missing unit in Datadog query responses - #81
Closed
sentry-junior[bot] wants to merge 1 commit into
Closed
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Datadog's v1 query API now omits series[].unit for metrics without unit metadata, which made warn_multiple_units raise KeyError and fail every run. Refs PRODENG-2990 Co-Authored-By: Bojan Oro <bojan.oro@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since about 02:00 UTC on Oct 23, the hourly usage-accountant cronjob has been failing in every region with
KeyError: 'unit'inwarn_multiple_units.Datadog's v1 query API (
/api/v1/query) now leavesseries[].unitout completely when a metric has no unit set in Datadog. Before, the field was there with null values. The*.cogs.usagemetrics have no unit set.main()already handles this, because every query in our config sets its own unit. Butwarn_multiple_unitsread the field without checking it exists, so this warning-only helper was failing the whole run.This change treats a missing
unitas "no units" and also guards against a one-element unit list. Tests are added for both cases.Refs PRODENG-2990: Investigate usage accountant failures across all regions
via bojan.
--
View Junior Session [Sentry]