Repository navigation
build(deps): Bump andybalholm/brotli to 1.2.7 - #756
Merged
Merged
Conversation
Picks up the port of the CVE-2026-111497 decoder fix (invalid block switches are now reported as a format error). vroom decodes Content-Encoding: br request bodies with this package in internal/httputil/decompress.go. Refs VULN-3216 Co-Authored-By: Geoff Goldsmith <geoff.goldsmith@sentry.io> Co-Authored-By: Matt Quinn <354504+mjq@users.noreply.github.com>
sentry-junior
Bot
force-pushed
the
vuln-3216/andybalholm-brotli-1.2.7
branch
from
October 26, 2026 19:30
e743725 to
163d7d8
Compare
mjq
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
github.com/andybalholm/brotlifrom v1.1.0 to v1.2.7 for VULN-3216 (Brotli CVE-2026-111497).The CVE is in Google's C decoder. This Go port had the same logic error, and v1.2.7 (Oct 23) ports the upstream fix: invalid block switches are now reported as a format error. In Go the bug can only crash the process, not run code (broccoli2shell.com). vroom is exposed because
internal/httputil/decompress.godecodesContent-Encoding: brrequest bodies with this package.Changed:
go.modandgo.sumonly. v1.2.7'sgo.modrequiresgithub.com/xyproto/randomstring, sogo mod tidyadded its hashes togo.sum. The module also gets pulled in indirectly throughCAFxX/httpcompression, and MVS resolves it to v1.2.7.Verified locally (golang:1.27, go1.27.3):
go mod verify,go build ./...,go vet ./...andgo test ./...all pass.Not verified: CI, and decoding of real production payloads.
via Geoff Goldsmith.
--
View Junior Session [Sentry]