Repository navigation
fix: re-pin the line to upstream v1.7.1 - #32
Merged
Merged
Conversation
v93 makes NewClient take functional options and return an error; the client is built from WithAuthToken and WithEnterpriseURLs, whose parse error is returned as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Upstream v1.7.1 contains creativeprojects#63 (go-github v93) and creativeprojects#62 (gofmt doc comments, sorted test imports), which the line carries as its own patches.
Change
Merges upstream v1.7.1 (
5dd040ba) into the line and drops the go-github v93 row and the doc-comment and sorted-import formatting from FORK.md. The line now differs from upstream only by the module path, x/crypto v0.58.0 and the empty-release-list patch (#20). Merge with a merge commit so v1.7.1 stays an ancestor of the line.