Preserve CRLF when stripping conflict markers - #2253
Open
oxura wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #983.
strip_conflict_markers_keep_ourswas rebuilding every retained line with\n, so a CRLF working tree silently shifted the byte offsets before attribution merging.This walks the content with
split_inclusive('\n')instead and copies retained slices directly. That keeps CRLF, LF, mixed endings, and the final-newline state exactly as they appeared on disk. It also avoids the temporaryVecand rejoin.I added a CRLF regression test that produced LF-only output before this change. The focused virtual-attribution tests now pass (13 tests), formatting is clean, and clippy is clean apart from the existing
collapsible_matchwarnings on current main with Rust 1.95.