Skip to content

test(handler): fix TestRelayRoutes flake on /hex/packages and /gem/info #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrew merged 1 commit into from
Oct 1, 2026
+5 −3
Merged

test(handler): fix TestRelayRoutes flake on /hex/packages and /gem/info #395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions internal/handler/relay_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,11 @@ func testRelayRoute(t *testing.T, route string, truncated bool) {
if !truncated {
_, _ = fmt.Fprint(rw, "0\r\nX-Checksum: verified\r\nX-Late: discovered-at-eof\r\nX-Private: still-secret\r\n\r\n")
}
if err := rw.Flush(); err != nil {
t.Error(err)
}
// Two of these routes fan out a second upstream request for cooldown
// timestamps and abandon its body on a non-200, so this may be writing to
// a connection the proxy has already dropped. What the proxy made of the
// response under test is asserted downstream.
_ = rw.Flush()
}))
defer upstream.Close()
proxy := testProxy()
Expand Down
Loading