Reduce default registry lookup allocations - #39
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues block approval.
Pull request overview
Reduces default registry lookup allocations by caching parsed hostnames while preserving TypeInfo mutation behavior.
Changes:
- Cache parsed default registry hosts.
- Avoid per-check configuration copies.
- Add compatibility tests and benchmarks.
File summaries
| File | Summary |
|---|---|
types.go |
Builds the default-host cache. |
makepurl_bench_test.go |
Adds construction and allocation benchmarks. |
defaults.go |
Uses cached hosts with mutation-safe fallback logic. |
defaults_cache_test.go |
Tests registry semantics and compatibility. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse parsed default-registry hostnames and avoid allocating a configuration copy for each registry check. This benefits PURL types with configured default registries while preserving caller URL parsing and changes made through
TypeInfo.Registry checks drop from 368 bytes and three allocations to 144 bytes and one allocation. In the mixed npm tarball benchmark, full PURL construction allocates 36% fewer bytes.