Use resolved scheme for emptiness check in ToVersString - #55
Merged
Merged
Conversation
ToVersString resolved its scheme argument but then called r.IsEmpty(), which re-read r.Scheme. A schemeless Range from NewRange with PyPI intervals was judged empty under the generic comparator and serialised as vers:pypi/. Fixes #52.
andrew
force-pushed
the
fix-toversstring-scheme
branch
from
September 26, 2026 08:38
6179250 to
0392d4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToVersStringresolves itsschemeargument (falling back fromr.Scheme) but then calledr.IsEmpty(), which re-readsr.Schemeto pick a comparator. A schemelessRangefromNewRangeholding PyPI intervals like>=2016.11.0|<3003rc1was judged empty under the generic comparator and serialised asvers:pypi/.IsEmptynow delegates to an unexportedisEmptyFor(scheme), andToVersStringcalls that with the scheme it already resolved.Fixes #52.