Repository navigation
Add accesslint to the list of scans in test workflow - #291
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Integration expectations must include AccessLint findings and issue titles so successful scans pass validation and the added scanner is actually tested.
1 open issue
What changed in this PR
Adds AccessLint to the integration workflow to broaden scan-and-file coverage, motivated by the label-creation failure reported in #260.
Changes:
- Enables
accesslintalongsideaxeandreflow-scanfor the test site.
| File | Description |
|---|---|
.github/workflows/test.yml |
Adds AccessLint to the integration scan list. |
Review effort: Max
Co-authored-by: helen <906334+helen@users.noreply.github.com>
| const actualWithoutAccesslint = actual.filter(({scannerType}) => scannerType !== 'accesslint') | ||
| expect(actualWithoutAccesslint).toHaveLength(expected.length) | ||
| expect(actualWithoutAccesslint).toEqual(expect.arrayContaining(expected)) | ||
| expect(actual.some(({scannerType}) => scannerType === 'accesslint')).toBe(true) |
kendallgassner
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this while cutting a new release for #260, seems like we should test all of the built-in scans. Might even have caught this earlier.