Repository navigation
test: mirror #224 ignore_https_errors input - #293
Closed
abdulahmad307 wants to merge 1 commit into
Closed
abdulahmad307 wants to merge 1 commit into
abdulahmad307 wants to merge 1 commit into
Conversation
…s-errors-self-signed-ssl # Conflicts: # .github/actions/find/action.yml # .github/actions/find/tests/findForUrl.test.ts # README.md
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The change still has an active critical issue because the existing forwarding test will fail until it is updated for the new sixth argument and an enabled-case test is added.
1 open issue
What changed in this PR
Adds an optional ignore_https_errors input to the accessibility scanner, allowing Playwright to scan sites with invalid or self-signed HTTPS certificates while preserving a secure default.
Changes:
- Documents and exposes the new input in the root and internal actions.
- Forwards the setting through the scanner to Playwright’s browser context.
- Adds coverage for enabled and disabled HTTPS-error behavior.
- The existing
index.test.tsforwarding assertion must be updated for the new sixth argument, including an enabled-input case.
| File | Summary |
|---|---|
README.md |
Documents the new top-level action input. |
action.yml |
Declares and forwards ignore_https_errors. |
.github/actions/find/tests/findForUrl.test.ts |
Tests enabled and disabled browser-context behavior. |
.github/actions/find/src/index.ts |
Loads and forwards the HTTPS-error setting. |
.github/actions/find/src/findForUrl.ts |
Applies Playwright’s ignoreHTTPSErrors context option. |
.github/actions/find/README.md |
Documents the internal find action input. |
.github/actions/find/action.yml |
Declares the input for the find action. |
Review effort: Lite (auto)
| includeScreenshots, | ||
| reducedMotion, | ||
| colorScheme, | ||
| ignoreHttpsErrors, |
Contributor
Author
|
closing this until the main PR (#224) is updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors the proposed
ignore_https_errorsinput from #224 in this repository so its checks can run here.Testing
npx vitest run .github/actions/find/tests/findForUrl.test.ts(25 tests passed)