CFG: Rename ForeachStmt to ForEachStmt. - #22489
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The mechanical rename is complete across the shared signature and all implementations, with no stale non-C# references found.
Review tier: Balanced
Findings: None
What changed in this PR
Renames the private CFG abstraction from ForeachStmt to ForEachStmt while preserving C#’s public ForeachStmt API.
Changes:
- Renames the shared CFG signature and internal references.
- Updates all language-specific implementations.
| File | Description |
|---|---|
shared/controlflow/codeql/controlflow/ControlFlowGraph.qll |
Renames the shared class and usages. |
unified/ql/lib/codeql/unified/internal/ControlFlowGraph.qll |
Updates the Unified implementation. |
ruby/ql/lib/codeql/ruby/controlflow/ControlFlowGraph.qll |
Updates the Ruby stub implementation. |
python/ql/lib/semmle/python/controlflow/internal/AstNodeImpl.qll |
Updates Python implementation and cast. |
java/ql/lib/semmle/code/java/ControlFlowGraph.qll |
Updates the Java implementation. |
csharp/ql/lib/semmle/code/csharp/controlflow/internal/ControlFlowGraph.qll |
Updates the private adapter while preserving the public C# name. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| final private class FinalForeachStmt = CS::ForeachStmt; | ||
|
|
||
| class ForeachStmt extends FinalForeachStmt { | ||
| class ForEachStmt extends FinalForeachStmt { |
hvitved
approved these changes
Sep 2, 2026
owen-mc
reviewed
Sep 2, 2026
| @@ -190,7 +190,7 @@ module Ast implements AstSig<Location> { | |||
|
|
|||
| final private class FinalForeachStmt = CS::ForeachStmt; | |||
Contributor
There was a problem hiding this comment.
Worth renaming FinalForeachStmt and similar at the same time?
Contributor
Author
There was a problem hiding this comment.
I'll do C# in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames all the instances that are effectively private (everything except C#).