[DO NOT MERGE] Partner pack#309
Merged
Merged
Conversation
ashleywolf
requested review from
AndreaGriffiths11,
LadyKerr,
cassidoo and
karasowles
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new “Partner Pack” section for Maintainer Month 2025, including content, navigation, and UI components.
- Introduce markdown files for each partner offer and related partner‐pack pages
- Add styles and React components to render the offers grid and integrate “Partner Pack” into the hero and header
- Update site navigation (commons.json & routes) and remove outdated event content
Reviewed Changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| content/partner-pack/offers/*.md | Added individual partner offer definitions |
| content/partner-pack/index.md | Created Partner Pack overview page |
| content/partner-pack/additional-sections.md | Added supporting sections (Want More, Our Partners) |
| content/home/4-2-get-involved-partners.md | Updated “Get Involved” copy to reference partner pack |
| content/home/4-1-get-involved-maintainers.md | Updated maintainer guidance to include partner pack |
| content/events/2025-05-01-Welcome.md | Removed obsolete welcome event |
| content/commons.json | Added “Partner Pack” to site navigation |
| common/routes.js | Defined PARTNER_PACK route |
| components/partner-pack/offers/offers.scss | Styles for offers grid and cards |
| components/partner-pack/offers/Offers.jsx | Render partner offers and additional sections |
| components/home/hero/hero.scss | Added styling for hero button group |
| components/home/hero/Hero.jsx | Added “Get the partner pack” call‐to‐action in hero |
| components/header/Header.jsx | Inserted Partner Pack link into header nav |
Comments suppressed due to low confidence (1)
components/partner-pack/offers/offers.scss:1
- There's no styling for
.offers-grid-container, yet it's used in the Offers JSX; consider adding styles or removing the unused wrapper.
// Override the section-divider styling for the partner pack page
| <div className="hero__buttons"> | ||
| <ButtonLink href={buttonLink}>{buttonText}</ButtonLink> | ||
|
|
||
| <ButtonLink href={ROUTES.PARTNER_PACK.path}>Get the partner pack</ButtonLink> |
There was a problem hiding this comment.
Use ROUTES.PARTNER_PACK.getPath(year) instead of ROUTES.PARTNER_PACK.path to ensure the link includes the current year prefix.
Suggested change
| <ButtonLink href={ROUTES.PARTNER_PACK.path}>Get the partner pack</ButtonLink> | |
| <ButtonLink href={ROUTES.PARTNER_PACK.getPath(currentYear)}>Get the partner pack</ButtonLink> |
Comment on lines
+49
to
+50
| wantMoreLinkText, | ||
| wantMoreLinkUrl, |
There was a problem hiding this comment.
The wantMoreLinkText and wantMoreLinkUrl properties are destructured but never used; consider removing them to clean up the code.
Suggested change
| wantMoreLinkText, | |
| wantMoreLinkUrl, |
Comment on lines
+69
to
+70
| {publicOffers.map((offer, index) => ( | ||
| <OfferCard key={index} offer={offer} /> |
There was a problem hiding this comment.
[nitpick] Using the array index as the key can lead to rendering issues; consider using a unique identifier like offer.name instead.
Suggested change
| {publicOffers.map((offer, index) => ( | |
| <OfferCard key={index} offer={offer} /> | |
| {publicOffers.map((offer) => ( | |
| <OfferCard key={offer.name} offer={offer} /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Updating the site with the partner pack for Maintainer Month