Repository navigation
fix(commandline): running previously focused commandline row when none is visible - #372
Open
suveshmoza wants to merge 3 commits into
Open
suveshmoza wants to merge 3 commits into
suveshmoza wants to merge 3 commits into
Conversation
Drop the previously focused row when the completion list has nothing to show, so `<Enter>` does not execute it.
suveshmoza
changed the title
commandline row when none is visiblecommandline row when none is visible
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no rows are available in the
commandline, pressing<Enter>executes the previously focused row instead of closing thecommandlinewithout executing anything.Steps to reproduce
:mapcommandline<Enter>The previously focused
:maprow is executed, opening the key mappings page, even though no matching rows are available.Changes:
<Enter>no longer runs a commandline row once the filter hides every option. The widget forgets the focused row, and accept skips a hidden one. Accepting a row removes its focused class before closing.This also fixes
Uncaught (in promise) InternalError: too much recursionerror when runningcommandline_acceptglide-before.mp4
glide-after.mp4