"unchanged" was too strong for the kernel pool walk - #185
Merged
Merged
Conversation
A kernel session is not asked about commitment, so the pool walk classifies exactly as before and its coverage is identical. That is not the same as unchanged, which this entry claimed: the `walk_vs` site it makes noisy is silent on a kernel too, and now names the chunks it drops. Measured on a live 26100 kernel over KDNET (`ctf-vm`, 2026-09-24) on this pin: 633,665 chunks walked, `coverage: partial`, the walk returning in 42.3s inside its budget — and the new shape is the **largest** on that target at 2,768 occurrences, beside 2,617 of the unchanged "region # is only committed through #". Those chunks were dropped before this change as well and already cleared `complete`; nothing in the answer said which, or how many. So what rises is `PoolDiagnostics::emitted`, which is the improvement rather than a regression — and anything thresholding on that count will see it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MUhLUt9rB6zd42Y25btB3h
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog prose only, correcting a claim #183 made about itself once a live kernel could be walked on that pin.
#183 said "The kernel pool walk is not asked at all and is unchanged." The first half is right and the second is not. A kernel session is never asked about commitment, so the walk classifies exactly as before and its coverage is identical — but the
walk_vssite #183 made noisy is silent on a kernel too, and now names the chunks it drops.Measured
ctf-vm, live 26100 over KDNET, 2026-09-24, on28dd63d:Inside its budget, so the conservative path is the one a kernel takes and it costs nothing —
committed_runis gated onis_kernel_targetbefore any engine query. The new shape is the largest on that target:VS chunk at # is # bytes and runs # past the committed extent at #; no span is emitted for itregion # is only committed through # unreadable space extends # bytesThose 2,768 chunks were dropped before #183 as well, and the site already cleared
complete; nothing in the answer said which, or how many. So what rises isPoolDiagnostics::emitted, which is the improvement rather than a regression — and anything thresholding on that count will see it.Not a before/after against
windbg-mcpFOLLOWUPS item 100's table. That run was a different build on a differently-loaded guest (783,042 chunks at 88.1% allocated, against 633,665 at 70.2% here), so its 207 and this 2,617 are two readings of two machine states. What says the unchanged shape is unchanged is the third arm oftest_a_gap_with_nothing_behind_it_is_not_worth_a_diagnostic— the kernel case exactly, a source that cannot be asked still emitting it — and the conditional #183 added can only make that diagnostic fire less, never more.The whole live-kernel tier passed on this pin: 10 tests, 0 failed, 1,263s, guest uptime advancing 6.013s across a 4s detach and every patched byte restored.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MUhLUt9rB6zd42Y25btB3h