Skip to content

"unchanged" was too strong for the kernel pool walk - #185

Merged
glslang merged 1 commit into
mainfrom
kernel-walk-is-not-unchanged
Sep 24, 2026
Merged

glslang merged 1 commit into
mainfrom
kernel-walk-is-not-unchanged

Conversation

@glslang

@glslang glslang commented Sep 24, 2026

Copy link
Copy Markdown
Owner

Changelog prose only, correcting a claim #183 made about itself once a live kernel could be walked on that pin.

#183 said "The kernel pool walk is not asked at all and is unchanged." The first half is right and the second is not. A kernel session is never asked about commitment, so the walk classifies exactly as before and its coverage is identical — but the walk_vs site #183 made noisy is silent on a kernel too, and now names the chunks it drops.

Measured

ctf-vm, live 26100 over KDNET, 2026-09-24, on 28dd63d:

633,665 chunks walked (444,836 allocated), coverage: partial, 42.3s

Inside its budget, so the conservative path is the one a kernel takes and it costs nothing — committed_run is gated on is_kernel_target before any engine query. The new shape is the largest on that target:

shape count
VS chunk at # is # bytes and runs # past the committed extent at #; no span is emitted for it 2,768
region # is only committed through # unreadable space extends # bytes 2,617
everything else, 9 shapes 94

Those 2,768 chunks were dropped before #183 as well, and the site already cleared complete; nothing in the answer said which, or how many. So what rises is PoolDiagnostics::emitted, which is the improvement rather than a regression — and anything thresholding on that count will see it.

Not a before/after against windbg-mcp FOLLOWUPS item 100's table. That run was a different build on a differently-loaded guest (783,042 chunks at 88.1% allocated, against 633,665 at 70.2% here), so its 207 and this 2,617 are two readings of two machine states. What says the unchanged shape is unchanged is the third arm of test_a_gap_with_nothing_behind_it_is_not_worth_a_diagnostic — the kernel case exactly, a source that cannot be asked still emitting it — and the conditional #183 added can only make that diagnostic fire less, never more.

The whole live-kernel tier passed on this pin: 10 tests, 0 failed, 1,263s, guest uptime advancing 6.013s across a 4s detach and every patched byte restored.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MUhLUt9rB6zd42Y25btB3h

A kernel session is not asked about commitment, so the pool walk classifies
exactly as before and its coverage is identical. That is not the same as
unchanged, which this entry claimed: the `walk_vs` site it makes noisy is
silent on a kernel too, and now names the chunks it drops.

Measured on a live 26100 kernel over KDNET (`ctf-vm`, 2026-09-24) on this
pin: 633,665 chunks walked, `coverage: partial`, the walk returning in 42.3s
inside its budget — and the new shape is the **largest** on that target at
2,768 occurrences, beside 2,617 of the unchanged "region # is only committed
through #". Those chunks were dropped before this change as well and already
cleared `complete`; nothing in the answer said which, or how many. So what
rises is `PoolDiagnostics::emitted`, which is the improvement rather than a
regression — and anything thresholding on that count will see it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MUhLUt9rB6zd42Y25btB3h
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 87ae0179-5049-48ae-8542-dcb49d560fd7


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@glslang
glslang merged commit 5b1725a into main Sep 24, 2026
7 checks passed
@glslang
glslang deleted the kernel-walk-is-not-unchanged branch September 24, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant