Repository navigation
feat(domain): add auto-renew and transfer-lock set commands - #348
Merged
jpage-godaddy merged 1 commit intoOct 22, 2026
Merged
Conversation
…T-320] Expose the Domains v3 setAutoRenew and setTransferLock mutations as `gddy domain auto-renew set` and `gddy domain transfer-lock set`, with step-up scope domains.domain:update. Includes the implementation proposal. Co-authored-by: Cursor <cursoragent@cursor.com>
rts1-godaddy
requested review from
axburgess-godaddy,
jpage-godaddy,
jpearlman-godaddy,
mguerrero3-godaddy and
qcai-godaddy
as code owners
October 22, 2026 19:33
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Security-sensitive mutations have unresolved dry-run safeguards, and runtime safety remains unverified, requiring human review.
2 open issues
What changed in this PR
Adds domain-setting commands to the GoDaddy CLI using the Domains v3 API and the step-up domains.domain:update scope.
Changes:
- Adds auto-renew and transfer-lock toggles with mutually exclusive
--enableand--disableflags. - Returns operation details and follow-up commands for asynchronous updates.
- Registers both commands and extends authentication and sensitive-scope tests.
| File | Description |
|---|---|
rust/src/scopes/tests.rs |
Adds domain updates to the expected step-up scopes. |
rust/src/scopes/declarations.rs |
Declares the sensitive domain-update scope. |
rust/src/domain/transfer_lock.rs |
Implements transfer locking and unlocking. |
rust/src/domain/mod.rs |
Registers both command groups and extends help and authentication tests. |
rust/src/domain/auto_renew.rs |
Implements automatic-renewal toggles. |
Review effort: Balanced
jpage-godaddy
approved these changes
Oct 22, 2026
jpage-godaddy
deleted the
feature/GDDEVPLAT-320-auto-renew-transfer-lock
branch
October 22, 2026 23:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://godaddy-corp.atlassian.net/browse/GDDEVPLAT-320
Expose the Domains v3 setAutoRenew and setTransferLock mutations as
gddy domain auto-renew setandgddy domain transfer-lock set, with step-up scope domains.domain:update. Includes the implementation proposal.