Repository navigation
fix(domain): say quoted prices exclude taxes and fees, and show the order after purchase [GDDEVPLAT-389] - #349
Merged
Merged
Conversation
jpage-godaddy
requested review from
axburgess-godaddy,
jpearlman-godaddy,
mguerrero3-godaddy,
qcai-godaddy and
rts1-godaddy
as code owners
October 22, 2026 21:08
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The shared order next action uses a parameter key that does not match the target command’s argument, violating the documented structured-action contract.
1 open issue
What changed in this PR
Clarifies that domain registration quotes exclude taxes and fees, and connects purchase results to the order showing the actual charge without adding order-read authorization to the purchase flow.
Changes:
- Updates price labels, premium-fee headings, help, and consent guidance.
- Adds an optional order ID and quoted-price note to purchase output.
- Adds order lookup next actions and regression tests.
| File | Description |
|---|---|
| rust/src/domain/suggest.rs | Clarifies price exclusions and premium-fee headings. |
| rust/src/domain/quote.rs | Updates price labels, purchase guidance, and tests. |
| rust/src/domain/purchase.rs | Returns order details and clarifies quoted prices and consent. |
| rust/src/domain/operation.rs | Adds an order lookup next action. |
| rust/src/domain/mod.rs | Updates shared AI-assistant purchase confirmation guidance. |
| rust/src/domain/guides/domain-purchase.md | Explains additional charges and post-purchase order lookup. |
| rust/src/domain/common.rs | Adds shared price wording and an order-action helper with tests. |
| rust/src/domain/available.rs | Clarifies premium fees and price exclusions. |
Review effort: Balanced
axburgess-godaddy
approved these changes
Oct 22, 2026
…rder after purchase [GDDEVPLAT-389]
The price shown by `domain suggest`, `available` and `quote` is the registration price only. The ICANN fee and any tax are added when you register, so the total charged is higher (a test purchase quoted at 9.19 USD was charged 9.39 USD).
- Say so where the price appears: the `quote` next step ("plus applicable taxes and fees"), the `Price` label, the `available` and `suggest` next steps, command help, the purchase guide and the `--confirm` prompt. The guide no longer claims you are charged exactly what the quote showed.
- Rename the `Fees` columns to `Premium Fees`. They list only a premium domain's extra cost and are empty for an ordinary domain, which previously read as "no fees".
- `domain purchase` now returns the `orderId` and notes that `price` is the quoted price, not the amount charged. Its next steps point to `shopping order get <order-id>`, which shows the total charged. `domain operation status` does the same once an order exists.
- Tell AI assistants to relay that taxes and fees are added on top of the quoted price before they ask for consent.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jpage-godaddy
force-pushed
the
icann-and-taxes
branch
from
October 22, 2026 23:57
cb997d4 to
32c9d35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
The price shown by
domain suggest,availableandquoteis the registration price only. The ICANN fee and any tax are added when you register. In a test-environment purchase, a.comquoted at 9.19 USD was charged 9.39 USD (ICANN fee 0.20, tax 0 on that account). Until now nothing in the CLI said so:domain quotepresented the price as final, and the guide said "you're charged exactly what the quote showed".Feescolumn was blank for ordinary domains, which reads as "no fees". It only ever lists a premium domain's extra cost.domain purchaseprintedprice: 9.19after the charge, which looks like a receipt but is the quote echoed back.Fixes GDDEVPLAT-389. Follows GDDEVPLAT-388 (API docs now state that v3 prices exclude taxes and fees).
What changed
quotenext step now reads "Register at the quoted price (plus applicable taxes and fees) within ~10 minutes — requires --agree and --confirm." Thequoteprice is labelledPrice (before taxes and fees). Theavailableandsuggestnext steps say "Prices exclude applicable taxes and fees." Command help, thedomain-purchaseguide and the--confirmprompt say the same, and the false "exactly what the quote showed" claim is gone.Feescolumns are nowPremium Feesinquote,availableandsuggest. JSON field names are unchanged.domain purchasereturns theorderIdand anotesayingpriceis the quoted price, not the amount charged.priceandcurrencykeep their names, so existing scripts are unaffected. Its next steps includeshopping order get <order-id> --wait, which shows the total charged.domain operation statusoffers the same next step once an order exists.Design note
purchasedoes not look up the order total itself.shopping.order:readis a step-up-only scope, so adding it would make every domain buyer re-consent, and calling the order API without it would fail for most users. The total is one suggested command away, and only users who run it step up.Testing
cargo check,cargo clippy --workspace -- -D warnings,cargo fmt --check,cargo test --workspaceandcheck-module-size.shall pass.quotenext step in its human and AI-assistant forms, the price label, thepurchaseresult (order ID and note, no JSON nulls when absent), and the order next step.orderId, the note and the order next step, andshopping order getshowed a total of 9.39 USD against the 9.19 USD quote.🤖 Generated with Claude Code