Repository navigation
Mark GodotInstance as a Core type - #1709
Merged
Merged
Conversation
Bromeon
added
quality-of-life
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1709 |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 1, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds GodotInstance as a Core type.
References #1488
Libgodot is technically usable with this (the start() function cannot be called when not registered as Core), but it needs manually loading of the library and calling of the exposed libgodot_create_godot_instance function to get a sys pointer to a GodotInstance (and libgodot_destroy_godot_instance for cleanup), so I don't think it fully resolves it.