release: v0.34.1 — remove ALL type aliases (ADR-073) - #345
Merged
Conversation
Google Go style guide: 'Don't use type aliasing when it is not needed.' Russ Cox: aliases are for gradual code repair, stage 3 = REMOVE. Go stdlib: zero convenience aliases in 17 years. Kubernetes (3M+ LOC): qualified imports, zero aliases. Our data: 94.6% of ecosystem callers (580/613) already used gputypes directly. The 35 aliases in types.go served 33 of 613 use cases. gputypes was created as the canonical shared types package — users should import it directly. IDE auto-import handles the extra line. 97 files changed, net -63 LOC (aliases removed > qualified refs added). Closes #342 (partially — hal alias cleanup complete)
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove all 42 gputypes type aliases — use qualified
gputypes.Ximports directly (ADR-073).Why
Google Go style guide: "Don't use type aliasing when it is not needed." Our data: 94.6% of ecosystem callers already used gputypes directly. Aliases served 33 of 613 use cases. Go type aliases are designed for migration (Russ Cox, Go 1.9), not permanent architecture. Users import gputypes alongside wgpu — IDE auto-import, zero friction.
99 files, net -63 LOC.
Test plan