fix: implement missing GLSL.std.450 opcodes (#334) - #350
Open
lkmavi wants to merge 2 commits into
Open
Conversation
…reter Stop silent zero returns for unimplemented ExtInst ops (#334): align Khronos opcode numbers, warn on unknowns, and implement matrix/pack/split/bit/geom ops with ≥86% package coverage.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Determinant/MatrixInversewere 76/77; correct values are 33/34) and implement the remaining GLSL.std.450 ExtInst ops in the software SPIR-V interpreter.hal.Logger().Warnon unknown opcodes to stop silent zero corruption on CI/servers/software backend.Closes #334
Test plan
go test ./hal/software/shader— coverage 86.2% (≥86%)go test ./...golangci-lint run --timeout=5m