Repository navigation
Conversation
nehal-a2z
marked this pull request as ready for review
September 16, 2026 12:18
nehal-a2z
force-pushed
the
nehal/toy-mean-ci-metric
branch
from
October 5, 2026 02:46
5c60333 to
210be76
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Configuring
CIMeanPerComponentfor a toy run currently parses but fails when the evaluator is built. Bind the existing metric through the currentStandaloneOperationPlanAPI to held-out toy evaluation batches so TMS and ResidMLP can emit its linear/log plots on the configured slow cadence. Reuse the shared lower-CI reducer and renderer, pooling sums and example counts across all evaluation batches.Related Issue
Related to #242: provides an existing diagnostic for toy investigations. This PR does not resolve the scientific question in that issue.
Motivation and Context
Toy runs already support authored UV figures but reject the mean-CI plots needed to inspect highly active components. This adds the missing binding while preserving the existing figure keys, schema, and W&B requirement. It does not enable another evaluation by default.
How Has This Been Tested?
git diff --checkpass.Rebased onto main
017a17af; uses the current decomposition/CI lifecycle and prepares the compiled reduction before running evaluation.The intentional all-zero case retains the existing renderer's log-axis warning. Full training, the full suite, and live W&B uploads were not run.
Does this PR introduce a breaking change?
No. This binds one existing, explicitly requested metric; existing configurations and other evaluators are unchanged.
Sent from Autobox