Centralize Gemma 4 sliding attention masking - #792
Open
Nerdman3214 wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attentionattention_maskandsliding_attention_maskthroughTransformerskip_sliding_maskwith the clearerdisable_sliding_windowintent flagDetails
Previously,
Transformerselected betweenattention_maskandsliding_attention_maskbefore calling the block, while_modules.pyalsocontrolled application of the sliding-window mask. This split responsibility
for the final effective mask across multiple modules.
This change moves that responsibility into
Attention:attention_masksliding_attention_maskwhen providedAttentiondisable_sliding_window=Trueskips only the automatic window constraintTransformernow forwards the raw masks without making an attention-typedecision.
The diffusion gradient-checkpointing wrapper is also updated for the new
arguments.
sliding_attention_maskremains a dynamic JAX argument, whiledisable_sliding_windowis treated as the static boolean argument.Testing
python -m pytest gemma/gm/nn/gemma4 -qpy_compileskip_sliding_maskAPI is no longer referenceddisable_sliding_window=Falseanddisable_sliding_window=Truegit diff --checkpassesFixes #662