Member directory

[aojea]

No description provided.

[gemini-code-assist]

Code Review

This pull request introduces configurable DHT replication and reprovide intervals for nodes, allowing better control over how service records are published and looked up across routers. It also establishes authenticated directory sessions with unattached routers to reuse connections, and prunes the DHT routing table when routers leave the catalog. The review feedback suggests optimizing lock contention and reducing memory allocations in internal/node/directory.go by consolidating lock acquisitions and avoiding temporary map allocations in authDirectoryRouter and DirectoryRouters.

[gemini-code-assist]

6. Behavior must be auditable from logs and metrics / Efficiency

The authDirectoryRouter function currently performs multiple sequential lock acquisitions on n.mu by calling n.isAttached(router), n.isAuthenticatedAndConnected(router), and n.isCatalogRouter(router) back-to-back. Each of these helper functions acquires and releases the lock individually, leading to unnecessary lock contention and overhead.

We can optimize this by acquiring the lock once, extracting the required state, and performing the checks.

func (n *AgentMeshNode) authDirectoryRouter(ctx context.Context, router peer.ID) {
	n.mu.Lock()
	attached := n.attached[router]
	authenticated := n.authenticatedRouters[router]
	isCatalog := false
	for _, c := range n.routerCatalog {
		if c.ID == router {
			isCatalog = true
			break
		}
	}
	n.mu.Unlock()

	if attached || (authenticated && n.Host.Network().Connectedness(router) == network.Connected) || !isCatalog {
		return
	}

References

1. The style guide emphasizes clean, robust, and maintainable Go code. Minimizing lock contention and avoiding unnecessary allocations in hot paths like connection callbacks aligns with these principles. ^(link)

[gemini-code-assist]

6. Behavior must be auditable from logs and metrics / Efficiency

The DirectoryRouters function currently allocates a temporary map attached and calls n.authenticatedRouterIDs(), which locks n.mu again and allocates a temporary slice of peer IDs. This results in multiple lock acquisitions and unnecessary memory allocations.

We can optimize this by locking n.mu once and performing the checks directly on the live maps.

func (n *AgentMeshNode) DirectoryRouters() int {
	n.mu.Lock()
	defer n.mu.Unlock()
	count := 0
	for r := range n.authenticatedRouters {
		if !n.attached[r] && n.Host.Network().Connectedness(r) == network.Connected {
			count++
		}
	}
	return count
}

References

1. The style guide emphasizes clean, robust, and maintainable Go code. Minimizing lock contention and avoiding unnecessary allocations in hot paths like connection callbacks aligns with these principles. ^(link)