-
Notifications
You must be signed in to change notification settings - Fork 248
Extract channel mixing matrix construction out of AudioMixer #3200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jemoreira
merged 2 commits into
google:main
from
khamidjon-khamidov:audio-channel-matrix
Sep 23, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
base/cvd/cuttlefish/host/frontend/webrtc/audio_channel_matrix.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Copyright (C) 2026 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #include "cuttlefish/host/frontend/webrtc/audio_channel_matrix.h" | ||
|
|
||
| #include <algorithm> | ||
| #include <cstddef> | ||
| #include <cstdint> | ||
| #include <vector> | ||
|
|
||
| #include "absl/log/check.h" | ||
|
|
||
| namespace cuttlefish { | ||
|
|
||
| std::vector<std::vector<float>> BuildChannelMixingMatrix(uint8_t dst_channels, | ||
| uint8_t src_channels, | ||
| float volume) { | ||
| CHECK(volume >= 0) << "volume can't be negative"; | ||
|
|
||
| std::vector<std::vector<float>> matrix( | ||
| dst_channels, std::vector<float>(src_channels, 0.0f)); | ||
|
|
||
| // As of now we only use direct channel mapping | ||
| const size_t mapped_channels = std::min(dst_channels, src_channels); | ||
| for (size_t i = 0; i < mapped_channels; ++i) { | ||
| matrix[i][i] = volume; | ||
| } | ||
|
|
||
| return matrix; | ||
| } | ||
|
|
||
| } // namespace cuttlefish | ||
40 changes: 40 additions & 0 deletions
40
base/cvd/cuttlefish/host/frontend/webrtc/audio_channel_matrix.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /* | ||
| * Copyright (C) 2026 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <cstdint> | ||
| #include <vector> | ||
|
|
||
| namespace cuttlefish { | ||
|
|
||
| /** | ||
| * Builds the matrix used to mix a stream's source channels into a sink's | ||
| * destination channels. | ||
| * | ||
| * Each source channel is mapped to the destination channel of the same index | ||
| * and scaled by `volume`. Channels present on only one side are dropped. | ||
| * | ||
| * @param dst_channels Destination sink channels (e.g. 2 for a stereo sink) | ||
| * @param src_channels Source stream channels (e.g. 6 for 5.1 surround) | ||
| * @param volume Master stream volume [0.0 - 1.0] | ||
| * @return Mixing coefficients, indexed [destination channel][source channel] | ||
| */ | ||
| std::vector<std::vector<float>> BuildChannelMixingMatrix(uint8_t dst_channels, | ||
| uint8_t src_channels, | ||
| float volume); | ||
|
|
||
| } // namespace cuttlefish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.