Repository navigation
Drop stale loads in repositories.bzl after autobump cleanup - #356
Open
rootkiller6788 wants to merge 1 commit into
Open
rootkiller6788 wants to merge 1 commit into
rootkiller6788 wants to merge 1 commit into
Conversation
562fc9a deleted third_party/bazel.bzl and third_party/bazel_skylib.bzl but repositories.bzl still loads them. Nothing references the symbols they used to export, so the loads just fail whenever the async_profiler_repos extension is evaluated (bazel mod deps, IDE sync). Remove them.
rootkiller6788
marked this pull request as ready for review
October 12, 2026 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repositories.bzl still loads two files that the autobump cleanup deleted back in February (562fc9a): third_party/bazel.bzl and third_party/bazel_skylib.bzl. Nothing in the repo uses the symbols those loads export anymore, so they're pure breakage - any Bazel command that evaluates the async_profiler_repos module extension (bazel mod deps, mod tidy, IDE sync) dies with "cannot load '//third_party:bazel.bzl': no such file".
Normal bazel build //... never trips over it because nothing depends on the repos that extension creates, which is probably why it went unnoticed. Removing the two loads makes repositories.bzl load cleanly again.