-
Notifications
You must be signed in to change notification settings - Fork 302
x86: size CacheInfo::levels to hold all leaf 2 cache descriptors #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1399,6 +1399,24 @@ flags : fpu mmx sse sse2 pni ssse3 sse4_1 sse4_2 | |
| } | ||
|
|
||
| // https://www.felixcloutier.com/x86/cpuid#example-3-1--example-of-cache-and-tlb-interpretation | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line should stay next to its original test.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't seem to be addressed. Can you move this line so its stays close to the original test below? |
||
| // Regression test: a CPUID leaf 2 advertising the maximum number of cache/TLB | ||
| // descriptors must not overflow CacheInfo::levels. | ||
| TEST_F(CpuidX86Test, Leaf2_TooManyDescriptors_DoesNotOverflow) { | ||
| cpu().SetLeaves({ | ||
| {{0x00000000, 0}, Leaf{0x00000002, 0x756E6547, 0x6C65746E, 0x49656E69}}, | ||
| {{0x00000001, 0}, Leaf{0x00000F0A, 0x00010808, 0x00000000, 0x3FEBFBFF}}, | ||
| // Leaf 2 encodes one descriptor per byte across its four registers (16 | ||
| // bytes total). AL, the low byte of EAX, is the ignored count byte, so | ||
| // these all-0x01 registers forge 15 non-zero descriptors -- more than the | ||
| // old 10-entry CacheInfo::levels array and exactly filling the new 16. | ||
| {{0x00000002, 0}, Leaf{0x01010101, 0x01010101, 0x01010101, 0x01010101}}, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a comment below to indicate that we're forging 16 descriptors (one per byte). AL being discarded. so 15 descriptors. |
||
| }); | ||
|
|
||
| const auto info = GetX86CacheInfo(); | ||
| // All 15 descriptors are recorded, saturating the resized levels array. | ||
| EXPECT_EQ(info.size, 15); | ||
| } | ||
|
|
||
| TEST_F(CpuidX86Test, P4_CacheInfo) { | ||
| cpu().SetLeaves({ | ||
| {{0x00000000, 0}, Leaf{0x00000002, 0x756E6547, 0x6C65746E, 0x49656E69}}, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Size must at least 15" part is specific to x86, note that this data structure is cpu agnostic and can be filled for other CPUs. Can you update the comment to say that for x86 it needs to be at least 15?