Repository navigation
Fix cc_bindings_from_rs build on nightly Rust after ConstExt removal. - #2329
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_999083269
branch
from
October 14, 2026 04:41
d4ba814 to
3313eae
Compare
Upstream rust-lang/rust#163258 moved `try_to_target_usize` from the `ConstExt` extension trait to an inherent method on `Const`, and removed `ConstExt`. Gate `use ty::consts::ConstExt;` behind `#[rustversion::before(2026-10-13)]` so that `cc_bindings_from_rs` compiles both on nightlies that had the temporary `ConstExt` trait (2026-09-22 to 2026-10-12) and on newer nightlies (2026-10-13+) as well as stable toolchains where `try_to_target_usize` is an inherent method. PiperOrigin-RevId: 999104756
copybara-service
Bot
force-pushed
the
test_999083269
branch
from
October 14, 2026 04:59
3313eae to
7ac9e23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix cc_bindings_from_rs build on nightly Rust after ConstExt removal.
Upstream rust-lang/rust#163258 moved
try_to_target_usizefrom theConstExtextension trait to an inherent method on
Const, and removedConstExt.Gate
use ty::consts::ConstExt;behind#[rustversion::before(2026-10-13)]sothat
cc_bindings_from_rscompiles both on nightlies that had the temporaryConstExttrait (2026-09-22 to 2026-10-12) and on newer nightlies(2026-10-13+) as well as stable toolchains where
try_to_target_usizeis aninherent method.