[C++] Fix NULL pointer dereference in reflection VerifyVector() (union vector, CWE-476) - #9228
Open
thinhnallf wants to merge 2 commits into
Open
[C++] Fix NULL pointer dereference in reflection VerifyVector() (union vector, CWE-476)#9228thinhnallf wants to merge 2 commits into
thinhnallf wants to merge 2 commits into
Conversation
…n vector, CWE-476) VerifyVector()'s reflection::Union case can dereference a NULL type_vec pointer when a FlatBuffer's vtable has the union value-vector field present but the (implicit) companion type-vector field's slot absent. VerifierTemplate::VerifyVector(nullptr) intentionally returns true (a null vector is a valid, absent optional field), so a null type_vec is not rejected by the existing VerifyVector(type_vec) check, and the very next line dereferenced it unconditionally. Related to, but distinct from, google#8567 (already fixed): that issue was about a length mismatch between two non-null vectors; its fix added the size comparison seen here but never added a null-check for type_vec itself.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In
src/reflection.cpp, thereflection::Unioncase insideVerifyVector()can encounter a null pointer dereference iftype_vecis null.Since
VerifierTemplate::VerifyVector(nullptr)intentionally returnstrue(as a null vector represents a valid, absent optional field), a nulltype_vecsafely passes the verification line but subsequently causes an unconditional null pointer dereference during the size comparison.Fix
Add an explicit null-check for
type_vecimmediately after the verification check, before it is dereferenced.Testing
Confirmed locally that handling an absent companion type-vector field no longer causes a crash and is now correctly rejected by returning
false.