Skip to content

Verifier: size the size-prefixed identifier gate from the actual read window #9235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
esoalba wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Verifier: size the size-prefixed identifier gate from the actual read window #9235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49ab6d5
Verifier: size the size-prefixed identifier gate from the actual read…
esoalba Sep 9, 2026
e3b7caa
CLA: re-trigger cla/google check
esoalba Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions include/flatbuffers/verifier.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,14 @@ class VerifierTemplate FLATBUFFERS_FINAL_CLASS {
// this call and their size is determined at runtime.
if (!Check(size_ >= FLATBUFFERS_MIN_BUFFER_SIZE)) return false;

// If an identifier is provided, check that we have a buffer
if (identifier && !Check((size_ >= 2 * sizeof(flatbuffers::uoffset_t) &&
// If an identifier is provided, check that we have a buffer large
// enough for the identifier read: [start + sizeof(uoffset_t),
// start + sizeof(uoffset_t) + kFileIdentifierLength). The previous
// 2 * sizeof(uoffset_t) form only covers start == 0 and lets the
// identifier scan run past the end of the buffer for size-prefix
// layouts with larger SizeT (e.g. uoffset64_t).
if (identifier && !Check((size_ >= start + sizeof(flatbuffers::uoffset_t) +
kFileIdentifierLength &&
BufferHasIdentifier(buf_ + start, identifier)))) {
return false;
}
Expand Down